feat: allow specifying a custom font for the card text #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Awesome! @Daltz333 is there anything blocking merging this PR? We'd love to be able to use the social image card generation. |
Daltz333
approved these changes
Oct 27, 2023
|
Thanks! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #108
Hello, this PR implements the custom font setting and the default "Roboto" font. I encountered the same issue as #108 when I tried to use this for the Japanese translation of psycopg3 documentation. This should be helpful for any Sphinx project written in non-Latin languages.
I validated this change on the Debian container with Noto CJK font installed by
apt install fonts-noto-cjk. Here are examples:Before
After
I think this won't change the default Roboto Flex fallback behavior, but let me know if this needs any adjustment. Thanks.